Skip to content

Simplify WriteScanlines #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Simplify WriteScanlines #612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b2acaf
Simplify WriteScanlines
Shane32 Oct 1, 2025
2eae901
Merge branch 'master' into simplify_write_scanlines
Shane32 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions QRCoder/PngByteQRCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,7 @@ public void WriteScanlines(byte[] scanlines)
_stream.WriteByte(0x9C); // Check bits.

// Compressed data.
idatStream.Position = 0;
#if NET35
idatStream.WriteTo(_stream);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WriteTo writes the entire MemoryStream (disregarding position) to the target stream, and is a supported method across all .NET variations.

#else
idatStream.CopyTo(_stream);
#endif
// Deflate checksum.
var adler = Adler32(scanlines, 0, scanlines.Length);
WriteIntBigEndian(adler);
Expand Down