Skip to content

Conversation

@Akos299
Copy link
Collaborator

@Akos299 Akos299 commented Jul 17, 2025

No description provided.

@Akos299 Akos299 requested review from bcommerc and tdavidcl July 17, 2025 11:56
@Akos299 Akos299 added the draft label Jul 17, 2025
@github-actions
Copy link

Workflow report

workflow report corresponding to commit b1b2191
Commiter email is [email protected]
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 1
New warnings : 34
Warnings count : 6807 → 6840 (0.5%)

Detailed changes :
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:28: warning: Compound shammodels::basegodunov::modules::NodeComputeNewResidual is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:34: warning: Member NodeComputeNewResidual(u32 block_size, T alpha) (function) of class shammodels::basegodunov::modules::NodeComputeNewResidual is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:36: warning: Compound shammodels::basegodunov::modules::NodeComputeNewResidual::Edges is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:37: warning: Member sizes (variable) of struct shammodels::basegodunov::modules::NodeComputeNewResidual::Edges is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:38: warning: Member spans_phi_Ap (variable) of struct shammodels::basegodunov::modules::NodeComputeNewResidual::Edges is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:39: warning: Member spans_phi_res (variable) of struct shammodels::basegodunov::modules::NodeComputeNewResidual::Edges is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:42: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::Indexes< u32 > > sizes, std::shared_ptr< shamrock::solvergraph::IFieldSpan< T > > spans_phi_Ap, std::shared_ptr< shamrock::solvergraph::IFieldSpan< T > > spans_phi_res) (function) of class shammodels::basegodunov::modules::NodeComputeNewResidual is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:50: warning: Member get_edges() (function) of class shammodels::basegodunov::modules::NodeComputeNewResidual is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:58: warning: Member _impl_evaluate_internal() (function) of class shammodels::basegodunov::modules::NodeComputeNewResidual is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:60: warning: Member _impl_get_label() (function) of class shammodels::basegodunov::modules::NodeComputeNewResidual is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/CGComputeNewResidual.hpp:62: warning: Member _impl_get_tex() (function) of class shammodels::basegodunov::modules::NodeComputeNewResidual is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:35: warning: Member getptr_shared() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:36: warning: Member getptr_weak() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:38: warning: Member get_ro_edges() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:39: warning: Member get_rw_edges() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:41: warning: Member __internal_set_ro_edges(std::vector< std::shared_ptr< IDataEdge > > new_ro_edges) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:42: warning: Member __internal_set_rw_edges(std::vector< std::shared_ptr< IDataEdge > > new_rw_edges) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:45: warning: Member on_edge_ro_edges(Func &&f) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:48: warning: Member on_edge_rw_edges(Func &&f) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:56: warning: Member get_ro_edge(int slot) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:61: warning: Member get_rw_edge(int slot) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:65: warning: Member get_ro_edge_base(int slot) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:69: warning: Member get_rw_edge_base(int slot) (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:73: warning: Member evaluate() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:75: warning: Member get_dot_graph() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:76: warning: Member get_dot_graph_partial() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:77: warning: Member get_dot_graph_node_start() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:78: warning: Member get_dot_graph_node_end() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:80: warning: Member get_tex() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:81: warning: Member get_tex_partial() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:88: warning: Member _impl_get_dot_graph_partial() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:89: warning: Member _impl_get_dot_graph_node_start() (function) of class shamrock::solvergraph::INode is not documented.
+ src/shamrock/include/shamrock/solvergraph/INode.hpp:90: warning: Member _impl_get_dot_graph_node_end() (function) of class shamrock::solvergraph::INode is not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant