Skip to content

Add exception handling to report filter config loading in dashboard.py #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add exception handling to report filter config loading in dashboard.py #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d89a5dc
Initial plan
Copilot Oct 29, 2025
0632f49
Add exception handling to report filter config loading
Copilot Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/browsergym/workarena/tasks/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@
SUPPORTED_PLOT_TYPES = ["area", "bar", "column", "line", "pie", "spline"]

# Get report filter config
config = SNowInstance().report_filter_config
if config is None:
try:
config = SNowInstance().report_filter_config
except Exception as exc:
logging.warning("Failed to load report filter config: %s", exc)
REPORT_DATE_FILTER = REPORT_TIME_FILTER = None
else:
REPORT_DATE_FILTER = config["report_date_filter"]
REPORT_TIME_FILTER = config["report_time_filter"]
del config
if config is None:
REPORT_DATE_FILTER = REPORT_TIME_FILTER = None
else:
REPORT_DATE_FILTER = config["report_date_filter"]
REPORT_TIME_FILTER = config["report_time_filter"]
del config


class DashboardRetrievalTask(AbstractServiceNowTask, ABC):
Expand Down
Loading