-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add 'replace_output' props to plugin, allowing plugins to modif… #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zxypro1
wants to merge
16
commits into
main
Choose a base branch
from
zxy/dev-20250327
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y resource's output. Signed-off-by: zxypro1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/engine/src/actions/index.ts:26
- [nitpick] The record property 'replaceOutput' is using camelCase while the corresponding plugin prop is 'replace_output' (snake_case). Consider adding a comment to clarify this intentional naming conversion if it is not already documented.
replaceOutput: boolean;
Signed-off-by: zxypro1 <[email protected]>
Signed-off-by: zxypro1 <[email protected]>
Signed-off-by: zxypro1 <[email protected]>
Signed-off-by: zxypro1 <[email protected]>
…rsing - Update @serverless-devs/engine to 0.1.6-beta.8 - Update @serverless-devs/parse-spec to 0.0.30-beta.2 - Add 'override' option to dotenv config for consistent environment variable parsing Signed-off-by: zxypro1 <[email protected]>
- Update @serverless-devs/art-template in load-application, parse-spec, and registry packages - Bump version numbers in engine, load-application, parse-spec, and registry packages
- Add getNumberDefaultValue function to handle number type defaults - Update prompt generation to use getNumberDefaultValue for number type items - Bump version to 0.0.16-beta.3 Signed-off-by: zxypro1 <[email protected]>
…tion - Add error information to inputs for fail and complete hooks to improve error tracking. - Include hook context details in action inputs to provide better context during plugin execution. - Update the handling of outputs and statuses in the engine to ensure comprehensive error reporting. Signed-off-by: zxypro1 <[email protected]>
…dencies - Downgrade lockfileVersion from 9.0 to 6.0 in pnpm-lock.yaml. - Update various package versions in dependencies and devDependencies for consistency and compatibility. - Notable updates include @types/fs-extra, jest, and ts-node among others. Signed-off-by: zxypro1 <[email protected]>
…dling - Update package version in package.json to 0.1.6-beta.11. - Add appName parameter to Actions initialization for better context in action execution. - Update IOptions interface to include appName for improved clarity in resource and project actions. Signed-off-by: zxypro1 <[email protected]>
…ling context - Downgrade package version in package.json to 0.1.6-beta.10. - Change error handling to use 'errorContext' instead of 'error' for improved clarity in action execution. - Update inputs for fail and complete hooks to reflect the new error context structure. Signed-off-by: zxypro1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y resource's output.