Called 'ct_cacheVideo' inside 'ct_mediaLoaded'#13
Called 'ct_cacheVideo' inside 'ct_mediaLoaded'#13SezerYardim wants to merge 1 commit intoSeneral:masterfrom
Conversation
…achce simultaneously
|
Since this is a change not everyone wants (as it can take quite a lot of disk space) I would make it a separate option (that is OFF by default). The way to do that would be to just copy every occurance for the Cache First option (which in the same change also rename in the UI to "Always Use Cache"). A good name for the new option could be "Always Cache Audio". All those options would be a bit more complex to implement though. |
|
@Seneral So what you suggest is
Am i right ? If so, i know how to implement those but the problem is i am not 100% confident with the current codebase. Because it is just a single file with a lot of functions in it. Reading and understanding it from top to bottom is a little bit hard and confusing. So it would take a little longer than it requires |
|
Yeah just search to navigate. Also 4. is pretty complex to implement even for me, so I wouldn't attempt that, just use the existing implementation and wrap it in a parameter. Or I can try the other stuff later, either way we need another toggle |
Closes #8
I did what you mentioned in the issue. Called
ct_cacheVideoinsidect_mediaLoadedin order to cache and play simultaneously.Sorry for the commit message. I wasnt sure how to name it so if it is bad you can change it.