Skip to content

fix(mcp): tighten A2A and release verification - #145

Merged
roshanjonah merged 2 commits into
mainfrom
agent/a2a-conformance-verifiers
Aug 19, 2026
Merged

fix(mcp): tighten A2A and release verification#145
roshanjonah merged 2 commits into
mainfrom
agent/a2a-conformance-verifiers

Conversation

@roshanjonah

Copy link
Copy Markdown
Member

No description provided.

@roshanjonah roshanjonah added the major Logic or behaviour change requiring AI review label Aug 18, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f53fdda87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +77 to +79
if (process.argv.includes("--check")) {
const data = await checkMcpRegistryVersion({ name, version });
process.stdout.write(`${data ? "true" : "false"}\n`);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retry transient Registry errors during preflight

When either MCP release workflow runs --check during a transient Registry 429 or 5xx response, this direct call throws immediately even though checkMcpRegistryVersion explicitly marks that error as retryable. Both the recovery and normal publish workflows therefore abort before authentication or publication on the first transient response; route check mode through retry logic before deciding whether the version is already published.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7e14f36. The preflight now reuses the existing retry loop for transient 429/5xx responses while returning unpublished immediately for an exact 404. Added a red/green regression covering 503 then 404; all three Registry helper tests pass.

@roshanjonah
roshanjonah merged commit b54cb28 into main Aug 19, 2026
3 checks passed
@roshanjonah
roshanjonah deleted the agent/a2a-conformance-verifiers branch August 19, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Logic or behaviour change requiring AI review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant