ci: publish Snap edge builds - #114
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 570a86a489
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }} |
There was a problem hiding this comment.
Scope Snap Store credentials only to publishing
Because this secret is defined at job scope, every step receives SNAPCRAFT_STORE_CREDENTIALS, including the Snapcraft build that runs PR-controlled snap/** contents. For same-repository PRs or any merged change to snap/snapcraft.yaml, an override-build/build script can read and exfiltrate the store login before the publish-only if guard is evaluated, so the credential should be passed only to the publish/credential-check path rather than the whole job.
Useful? React with 👍 / 👎.
570a86a to
276c010
Compare
276c010 to
f9577a6
Compare
Summary
Verification