Skip to content

Deprecate 1k1k benchmark configurations#2263

Merged
adibarra merged 1 commit into
mainfrom
chore/deprecate-1k1k
Jul 18, 2026
Merged

Deprecate 1k1k benchmark configurations#2263
adibarra merged 1 commit into
mainfrom
chore/deprecate-1k1k

Conversation

@adibarra

@adibarra adibarra commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

As previously discussed, the time has come to deprecate 1k1k. 🫡

Summary

  • Remove all 1k1k fixed-sequence scenarios from the active NVIDIA and AMD master configs.
  • Archive the removed scenarios in:
    • configs/deprecated/nvidia-1k1k-master.yaml
    • configs/deprecated/amd-1k1k-master.yaml
  • Preserve all active 8k1k and agentic configurations.

Verification

  • Active master configs generate 0 fixed-sequence 1k1k jobs.
  • Active master configs generate 1,883 fixed-sequence 8k1k jobs.
  • Deprecated configs generate 1,831 fixed-sequence 1k1k jobs.
  • Verified that the archived and remaining scenarios exactly partition the original configurations.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@adibarra
adibarra merged commit 0094291 into main Jul 18, 2026
13 checks passed
@adibarra
adibarra deleted the chore/deprecate-1k1k branch July 18, 2026 01:50
Comment thread configs/amd-master.yaml
Comment thread configs/amd-master.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant