-
Notifications
You must be signed in to change notification settings - Fork 219
[DNM][AMD] agentx-v0.4 rebased from commit chore/agentx-v0.4 commit 823189e #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
147 commits
Select commit
Hold shift + click to select a range
f337475
[AMD] agentic: add hicache/lmcache configs, update agentic scripts fo…
seungrokj 35b174c
Add GLM5.1 & Qwen3.5 MI300 Agentic Scripts
ajith-sirra-amd 6fda587
[AMD] add DSV4-FP4-MI355x atom agentic benchmark and master yaml config
seungrokj 29f31e7
[AMD] update DSV4-FP4-MI355x atom agentic benchmark and master yaml c…
seungrokj c71b7b8
Add DSV4 MI355X Agentic Scripts
ajith-sirra-amd 9eba0ea
[AMD] dsv4_fp4_mi355x_atom.sh: update agentic benchmark script
seungrokj 47674f0
Add DSV4 MI355X Agentic Scripts
ajith-sirra-amd 777b953
[AMD] update DSV4-FP4-MI355X SGLang agentic benchmark and master yaml…
seungrokj c22841c
[AMD] update DSV4-FP4-MI355X SGLang agentic/fixed-seq-len benchmark s…
seungrokj 186b4e8
[AMD] remove unused CACHE_ARGS from dsv4_fp4_mi355x_sglang agentic sc…
seungrokj 456d3ac
[AMD] tune hicache ratio and disable none-offloading in agentic config
seungrokj 7b31de3
[AMD] remove --disable-radix-cache from dsv4_fp4_mi355x_sglang agenti…
seungrokj 054ab07
[AMD] add dsv4 sglang disagg
billishyahao 81643a5
recipe for agentic dsr1 fp4 and dsv4 fp4
ichbinblau 4e45ae5
fix image
billishyahao dbd4701
fix the image
billishyahao 2661637
fix
billishyahao 5819d87
fix
billishyahao 9134c82
bump image
billishyahao 38c0291
remove numactl
ichbinblau bcb4388
update dsv4 recipe
ichbinblau 232179d
update dsv4 agentic config and benchmark script
seungrokj d4d593e
bump sglang image for dsv4-fp4-mi355x-agentic-hicache
seungrokj 485fa5e
revert sglang image, comment out blk size 1 variant
seungrokj ccfdc6a
switch to sglang v0.5.13 image with page-size 1
seungrokj 472442c
test high con only in SA
ichbinblau 5c22d00
revert to v0.5.12 image with page-size 256
seungrokj fec7a42
update dsr1 agentic con=1
ichbinblau 5f30558
add hicache L3 support
ichbinblau c917cd8
dump commands in log files
ichbinblau c9932a4
bump to latest image and fix
ichbinblau ccf707a
fix
ichbinblau b75d467
Adding MINIMAX-M3 MI355X MXFP8 VLLM Agentic support
ajith-sirra-amd 53162fb
dsv4: fix prefill deadlock, kernel chunk cap, and router circuit-brea…
ichbinblau 203ea31
dsv4: move prefill/memory-pool patches into setup_deps and tune RDMA/…
ichbinblau b69e8d9
agentic: add 061326/061526 weka trace datasets and switch default to …
ichbinblau 2c58420
add more con list to dsv4 disagg agentic
ichbinblau b24759a
dsv4: bump sglang-rocm image to mi35x-20260618 for disagg-agentic-hic…
ichbinblau 0cb51e9
aiperf: bump submodule to 313c717
ichbinblau e82e00d
run higher con only
ichbinblau e53ecfa
fix runner bug
ichbinblau b69cbcc
lower the max running req
ichbinblau 6609035
Honor SCENARIO_SUBDIR so agentic-codin recipe is picked
ichbinblau 3b0b528
enable offloading:none
ichbinblau f6d6167
relax the router timeout
ichbinblau 6800ef0
add a patch to solve decode hang issue
ichbinblau d56716c
[AMD] add dsv4_fp4_mi355x_vllm agentic script and update kimik2.5/amd…
seungrokj bcc30b2
[AMD] fix dsv4_fp4_mi355x_vllm agentic script
seungrokj f4afbba
[AMD] update amd-master.yaml
seungrokj abf38a6
[AMD] fix missing total-cpu-dram-gb on hicache/lmcache agentic entries
seungrokj 12a3118
[AMD] update amd-master.yaml
seungrokj 020afc7
[AMD] set max-model-len 180000 for dsv4_fp4_mi355x_vllm agentic
seungrokj 49ef4a0
[AMD] remove VLLM_PREFIX_CACHE_RETENTION_INTERVAL from dsv4_fp4_mi355…
seungrokj d3f7227
agentic: flatten trace replay output and stage artifacts for CI upload
ichbinblau 1c04743
[AMD] reduce gpu-memory-utilization and max-model-len for dsv4_fp4_mi…
seungrokj 27805eb
[AMD] lower gpu-memory-utilization to 0.35 for lmcache offloading path
seungrokj e790769
Revert "[AMD] lower gpu-memory-utilization to 0.35 for lmcache offloa…
seungrokj aa08ff0
[AMD] fix lmcache hybrid kv cache manager flag and bump aiperf submodule
seungrokj 9480725
[AMD] restore --disable-hybrid-kv-cache-manager for lmcache path
seungrokj 1f89c12
[AMD] reduce max-model-len to 100000 for dsv4_fp4_mi355x_vllm agentic
seungrokj 04fe163
[AMD] add no-offloading baseline and expand conc-list for dsv4-fp4-mi…
seungrokj 49bcbda
[AMD] enable fp4 indexer cache and hybrid KV cache manager for mi355x…
seungrokj 0c350d4
[AMD] remove --attention_config.use_fp4_indexer_cache from dsv4_fp4_m…
seungrokj 2e251cc
[AMD] narrow dsv4-fp4-mi355x-vllm-agentic-lmcache conc-list to [16]
seungrokj 6448bae
[AMD] swap dsv4-fp4-mi355x-vllm-agentic-lmcache search-space to lmcac…
seungrokj e4fe570
agentic: nest per-conc trace replay output and scrape worker metrics
ichbinblau 5ce76d8
[AMD] forward TOTAL_CPU_DRAM_GB into container; enable hicache agenti…
ichbinblau 43be5da
[AMD] - Update Minimax-M3 FP8 MI355X Agentic Script
ajith-sirra-amd c8d1e1e
[AMD] - Update Minimax-M3 FP8 MI355X Agentic Script
ajith-sirra-amd 4b2c5c0
[AMD] add total-cpu-dram-gb to dsv4 hicache agentic entry to pass con…
ichbinblau 18294dc
[AMD] - Update Minimax-M3 FP8 MI355X Agentic Script
ajith-sirra-amd 9c21c35
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
ajith-sirra-amd 410de60
[AMD] add --shm=3000000 to srun for mi355x-amds launcher
seungrokj 20bda7c
[AMD] dsv4: quiet prefill/decode logs to error-only and use mooncake …
ichbinblau 1cd6934
[AMD] reduce shm to 1500000 and total-cpu-dram-gb to 2500 for lmcache
seungrokj d59767f
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
seungrokj 321ed00
[AMD] mount host /dev/shm into container for lmcache shm access
seungrokj 22dded7
[AMD] reduce total-cpu-dram-gb to 1500 for lmcache config
seungrokj 51786d2
agentic: one conc per multi-node allocation + fix LOGS cleanup
ichbinblau 0c3a877
[AMD] switch dsv4-fp4-mi355x-vllm-agentic-lmcache offloading to cpu
seungrokj 9af8633
[AMD] use mooncake-transfer-engine instead of rocm variant
seungrokj 1e1bc45
[AMD] use mooncake-transfer-engine-non-cuda for mi355x
seungrokj 2e409ed
[AMD] - Update Minimax-M3 FP8 MI355X Agentic Script - 3.0
ajith-sirra-amd 406b240
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
ajith-sirra-amd 179e518
[AMD] test ep8 dpa lmcache vs no-offloading for dsv4-fp4-mi355x-vllm-…
seungrokj 6f70bc4
[AMD] switch to ep1 dpa for lmcache vs no-offloading search-space
seungrokj efaeab6
[AMD] expand conc-list and add ep1 dpa/no-dpa lmcache search-space
seungrokj a112a5b
agentic: chown staged LOGS to runner user to fix EACCES on cleanup
ichbinblau 421f889
[AMD] tune dsv4-fp4-mi355x agentic disagg + SGLang plot support
ichbinblau 3155d97
[AMD] focus dsv4-fp4-mi355x sglang-disagg agentic sweep on hicache 32…
ichbinblau b21ae19
[AMD] - Update Minimax-M3 FP8 MI355X Agentic Script - CPU Offload
ajith-sirra-amd c3e5efc
[AMD] - Update Minimax-M3 FP8 MI355X Agentic Script - CPU Offload
ajith-sirra-amd 33c26ad
[AMD] narrow dsv4-fp4-mi355x lmcache search to ep1 no-dpa with conc-l…
seungrokj 0feb2a5
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
seungrokj 6879c7c
[AMD] increase dsv4-fp4-mi355x-vllm-agentic-lmcache duration to 3600s
seungrokj 35cccc5
[AMD] increase dsv4-fp4-mi355x-vllm-agentic-lmcache duration to 10800s
seungrokj 1381a92
[AMD] switch dsv4-fp4-mi355x-vllm-agentic-lmcache to cpu offloading d…
seungrokj d393545
[AMD] clear mooncake device_name for dsv4-fp4-mi355x vllm lmcache
seungrokj 307855a
[AMD] reduce total-cpu-dram-gb to 600 for dsv4-fp4-mi355x cpu offload…
seungrokj 9138294
[AMD] reduce mooncake local_buffer_size to 200MB to fix RDMA ENOMEM o…
seungrokj b5eb1f2
[AMD] switch mooncake protocol to tcp to bypass RDMA issues on mi355x
seungrokj 984cee1
[AMD] increase MOONCAKE_KV_LEASE_TTL to 3600s and add kv_load_failure…
seungrokj 7e9c55a
[AMD] revert kv_load_failure_policy=ignore from MooncakeStoreConnecto…
seungrokj 01cee2a
update con
ichbinblau f8e5eb2
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 8e84e0f
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
ajith-sirra-amd d1fba1e
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 47e5ff3
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 18c80c3
[AMD] increase Mooncake local_buffer_size to 4GB, MC_WORKERS_PER_CTX …
seungrokj 36b63b3
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd fdcb3d4
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
ajith-sirra-amd 94b2e43
[AMD] install RDMA/libcurl deps before mooncake for dsv4-fp4-mi355x c…
seungrokj e603e80
[AMD] build mooncake from source with RDMA support and switch protoco…
seungrokj 464547b
[AMD] reduce Mooncake local_buffer_size to 2GB to stay within RDMA ma…
seungrokj 73cd5ad
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 963776a
[AMD] switch Mooncake protocol back to tcp to avoid RDMA ENOMEM on mi…
seungrokj 56d9f2e
[AMD] disable patch_vllm_mooncake_transfer_batches and switch back to…
seungrokj 75ff18c
[AMD] add --ulimit memlock=-1 to srun for mi355x to allow RDMA memory…
seungrokj b4a1d8a
add more cache related metrics
ichbinblau fe283b8
[AMD] switch Mooncake back to tcp and remove --ulimit memlock=-1 (mem…
seungrokj a6406af
[AMD] set VLLM_PREFIX_CACHE_RETENTION_INTERVAL=32768 and MC_ENABLE_DE…
seungrokj cd1d383
[AMD] increase Mooncake local_buffer_size to 4GB for tcp mode on dsv4…
seungrokj c7fdde3
[AMD] re-enable patch_vllm_mooncake_transfer_batches for dsv4-fp4-mi3…
seungrokj 3c5dda2
remove con=40
ichbinblau 4263181
[AMD] reduce local_buffer_size to 2GB and add sleep 10 after mooncake…
seungrokj 0be0c1d
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 557e0dc
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
ajith-sirra-amd 7a3b97f
[AMD] add cleanup_agentic_services, disable mooncake transfer batch p…
seungrokj 411340d
[AMD] disable MC_ENABLE_DEST_DEVICE_AFFINITY for dsv4-fp4-mi355x cpu …
seungrokj 6e52229
[AMD] switch Mooncake protocol back to rdma for dsv4-fp4-mi355x cpu o…
seungrokj 2f4dcdc
[AMD] reduce Mooncake local_buffer_size to 256MB and re-enable transf…
seungrokj f087102
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 47b2a88
[AMD] add --mem=0 --propagate=STACK,MEMLOCK to srun and restore local…
seungrokj 96990ec
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd c861cbb
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
ajith-sirra-amd 66553f3
[AMD] fix dsv4-fp4-mi355x cpu offload: switch to tcp, enable_offload,…
seungrokj e473ead
[AMD] fix dsv4-fp4-mi355x cpu offload: set kv_lease_ttl=60s to enable…
seungrokj 229178b
[AMD] reduce warmup duration to 60s and set TCP user timeout for dsv4…
seungrokj 080acb3
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd b6c0067
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd c5883ee
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 8d3bbe5
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 1e6fea6
[AMD] update dsv4-fp4-mi355x-vllm-agentic: merge lmcache config, set …
seungrokj 98fdb3d
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd 82f608d
Merge branch 'amd/agentx-v0.4_rebase0611' of https://github.com/SemiA…
ajith-sirra-amd b96582a
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd b743a14
[AMD] MINIMAX-M3 FP4 VLLM LMCACHE AGENTIC
ajith-sirra-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disagg agentic uses wrong runner
High Severity
dsr1-fp4-mi355x-sglang-disagg-agentic-hicachesetsrunner: mi355xwhile sibling PD-disagg entries (includingdsv4-fp4-mi355x-sglang-disagg-agentic-hicache) userunner: mi355x-disagg. Multinode jobs useruns-on: ${{ inputs.runner }}, so the DSR1 agentic disagg matrix likely schedules on the wrong runner class.Additional Locations (1)
.github/configs/amd-master.yaml#L2848-L2857Reviewed by Cursor Bugbot for commit a9e1304. Configure here.