Skip to content

listwidget: fix template parameter #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

listwidget: fix template parameter #941

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d755ca
fix: render template
thomas-topway-it May 29, 2025
ef63770
fix phpcs
thomas-topway-it May 29, 2025
f5e8b89
fix comment
thomas-topway-it Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion formats/widget/SRF_ListWidget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,27 @@ public function getName() {
protected function getResultText( QueryResult $res, $outputmode ) {
// Initialize
static $statNr = 0;
// $this->isHTML = true;

$this->hasTemplates = ( $this->params['template'] !== '' );
$listType = $this->params[ 'listtype' ] === 'ordered' || $this->params[ 'listtype' ] === 'ol' ? 'ol' : 'ul';

$builder = new ListResultBuilder( $res, $this->mLinker );

$builder->set( $this->params );

$builder->set( [
'format' => $listType,
'link-first' => $this->mLinkFirst,
'link-others' => $this->mLinkOthers,
'show-headers' => $this->mShowHeaders,
] );

// this does not work, it would be preferable
// to find a way to disable links when template is used
// if ( $this->hasTemplates ) {
// $builder->set( [ 'link' => 'none' ] );
// }

// Get results from \SMW\Query\ResultPrinters\ListResultPrinter
$result = $builder->getResultText();

Expand Down Expand Up @@ -127,6 +134,10 @@ public function getParamDefinitions( array $definitions ) {
'default' => 5,
];

$params['template'] = [
'message' => 'smw-paramdesc-template',
'default' => '',
];
return $params;
}
}