Skip to content

fix: trim '-' from property labels before calling DIProperty::newFromUserLabel #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: trim '-' from property labels before calling DIProperty::newFromUserLabel #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion formats/datatables/SearchPanes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@

$qobj = $querySegmentList[$rootid];

$property = new DIProperty( DIProperty::newFromUserLabel( $printRequest->getCanonicalLabel() ) );
// lookup the property by the provided label, trim leading '-' to handle inverse properties
$property = new DIProperty( DIProperty::newFromUserLabel( ltrim( $printRequest->getCanonicalLabel(), '-' ) ) );

Check warning on line 130 in formats/datatables/SearchPanes.php

View check run for this annotation

Codecov / codecov/patch

formats/datatables/SearchPanes.php#L130 

Added line #L130 was not covered by tests
$propTypeid = $property->findPropertyValueType();

if ( $isCategory ) {
Expand Down