Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new tests and refactors the redirect logic for the "voices" module to ensure that requests for valid references are properly redirected to the "library" module, while invalid references return a 404 error. The most significant changes are the introduction of a dedicated redirect function and new tests to cover these cases.
Redirect logic improvements:
redirect_to_libraryfunction inreader/views.pyto handle permanent redirects from the "voices" module to the "library" module, preserving query parameters and determining the correct target domain based on language.reader/views.pyto useredirect_to_libraryfor valid references, and to return a 404 error for invalid references instead of redirecting.Testing enhancements:
test_voices_catchall_ref_redirects_to_libraryandtest_voices_catchall_non_ref_404inreader/tests/test_catchall_redirect.pyto verify that valid references are redirected to the library module and invalid references return a 404 error, using test-specific domain settings.