fix: resolve bounty issue #1 — implement Stripe PaymentIntent#724
Open
bomlinux92-byte wants to merge 1 commit into
Open
fix: resolve bounty issue #1 — implement Stripe PaymentIntent#724bomlinux92-byte wants to merge 1 commit into
bomlinux92-byte wants to merge 1 commit into
Conversation
- Replace stub implementation with real Stripe PaymentIntent via Stripe Node.js SDK - Add amount validation (required, positive integer in smallest currency unit) - Add currency default to 'usd' if not provided - Return clientSecret and paymentId from PaymentIntent - Handle Stripe errors and re-throw with original error message preserved - Add unit tests for validation logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for [BOUNTY $350] Implement Secure Payment Gateway and Payment Service — Issue #1
Root cause
The function in was a stub that returned fake payment IDs () instead of integrating with the Stripe API.
Fix
Changes
Acceptance Criteria met
Closes #1