Conversation
| """ | ||
|
|
||
| # Store the owner of a particular domain | ||
| domainOwner: public(map(string[40], address)) |
There was a problem hiding this comment.
don't you need @imp for all the fields?
There was a problem hiding this comment.
Wait, the original example doesn't have it either? Might be an internal-only thing or a missing requirement
There was a problem hiding this comment.
There should be a note in a comment if its an internal-only thing, or maybe something like @imp internal
There was a problem hiding this comment.
Ah, sometimes we called such things "derived requirements" if they're an implementation detail that doesn't directly link to an upstream requirement but helps implement one in practice.
Do all public getters need a requirement?
There was a problem hiding this comment.
Check out Line 20
There was a problem hiding this comment.
Well, idk, I've never done requirement before lol. But it seems logical that all public things need to be tied to requirements. And I guess private functions are implementation details and don't really matter.
Unless you start changing a private function and it affects a bunch of public methods - then you need to go over all of them...
2 participants
Summary
Add an implementation written in Vyper for the DNS example