Minor change to sshkey_paramiko.r2py. Replaced decode() with decode_next() #192
Open
xint-ong wants to merge 6 commits intoSeattleTestbed:masterfrom
Open
Minor change to sshkey_paramiko.r2py. Replaced decode() with decode_next() #192xint-ong wants to merge 6 commits intoSeattleTestbed:masterfrom
xint-ong wants to merge 6 commits intoSeattleTestbed:masterfrom
Conversation
replaced unsafe 'decode' call with 'decode_next'
| self.content = content | ||
| self.idx = 0 | ||
|
|
||
| def decode(self): |
Contributor
There was a problem hiding this comment.
I think it makes sense to add a comment to explain why you changed this. The reason is that at some point in the future, if we want to re-port the Paramiko library, we should know why this edit was done.
Author
There was a problem hiding this comment.
Thanks for the comment. I added a simple explanation to where the decode function was. Is this okay?
aaaaalbert
reviewed
Jun 29, 2017
sshkey_paramiko.r2py
Outdated
| def decode(self): | ||
| return self.decode_next() | ||
|
|
||
| # June 27, 2017: removed decode function, as it is not allowed by safe.py |
Contributor
There was a problem hiding this comment.
Sounds good. (The Git metadata contains the date however, so there's no real need to add it to the comment.)
aaaaalbert
added a commit
to aaaaalbert/repy-doodles
that referenced
this pull request
Jul 5, 2017
This just shows whether all non-UT RepyV2 files in this dir can be put into a VirtualNamespace without errors. If provided as a SeattleTestbed/seattlelib_v2 unit test, it would have caught SeattleTestbed/seattlelib_v2#192 easily. Note: This script doesn't provide `dylink` functions or the actual RepyV2 API to the checked libraries yet!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the decode() function calls with decode_next(), since decode is not allowed for safety reasons.
See the relevant repyV1 commit that introduced that safety check:
SeattleTestbed/repy_v1@bc6b6b9
Also, the same changes made to sshkey_paramiko.repy:
SeattleTestbed/seattlelib_v1@2d1262e?diff=unified