Identifying on which platform is Grease running

[tukanos]

Adding a platform testing code. It will make life easier for Magritte testing.

[jbrichau]

We're trying to avoid this kind of method but I do acknowledge that it is often very handy to have. So, let's add it to Grease.

However, Grease is also on the Squeak and VAST platforms (the code for the last one is not in this repo, but it exists). So I would prefer to list all supported platforms. Doing the check in this way means it will break silently when a class name changes. Although unlikely, I would like to recommend an implementation as follows:

GRPlatform>>#isGemStone, GRPlatform>>#isPharo, GRPlatform>>#isSqueak, GRPlatform>>#isVAST
^ false

GRPharoPlatform>>#isPharo
^ true

GRGemStonePlatform>>#isGemStone
^ true

GRGemStonePlatformTest>>testIsGemStone

self assert: GRPlatform current isGemStone.
self deny: GRPlatform current isPharo.
self deny: GRPlatform current isSqueak

The important thing here is that if we add it to Grease, it is expected to exist on all platforms and work. So, a test on each platform will need to be added.

[codecov]

Codecov Report

❌ Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.79%. Comparing base (a1954f8) to head (2d98f90).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
...-Core.package/GRPlatform.class/instance/isPharo.st	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   86.78%   86.79%           
=======================================
  Files        1860     1869    +9     
  Lines       12797    12840   +43     
=======================================
+ Hits        11106    11144   +38     
- Misses       1691     1696    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tukanos]

Funny is that my first/second commit was similar to what you wanted. I wanted to reduce the number of methods so I got fancy :). I have created the patch in a way that should now work for everyone.

I have also send PR for the information which dialects are consuming Grease.

[tukanos]

@jbrichau The failing test testFromStringThreeDigit in Pharo14 does not relate to tested code. Perhaps issue with test stability?