-
-
Notifications
You must be signed in to change notification settings - Fork 228
Refactor Value::Array and add Value::Enum #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Huliiiiii
wants to merge
19
commits into
SeaQL:master
Choose a base branch
from
Huliiiiii:value-array
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Still need to work on SeaORM to tweak the Enum design. |
This was referenced Nov 4, 2025
tyt2y3
added a commit
that referenced
this pull request
Nov 8, 2025
## PR Info - Closes #69 ## New Features - [ ] Provide a new type `RangeType` to implement Postgres range type - [ ] Provide range type as an element type of Postgres Array ## Doubts - [ ] Not sure where to implement `hashable-value` features. I put that in the `with_range.rs` - [ ] It implements time ranges with Chrono and Time I left out Jiff now - [ ] Not sure how it plays together with `with-json` - [ ] How to make RangeType from std Rust types (tuple, std range, how to describe exclusive and inclusive bounds?) - [ ] A refactor PR is going on which may affect this branch (#1004) --------- Co-authored-by: Chris Tsang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARRAY[instead ofARRAY [TODO: