Skip to content

Conversation

@ebbaoliveberg
Copy link
Contributor

@ebbaoliveberg ebbaoliveberg commented Nov 18, 2025

Pull Request Template

Before Marking as Ready for Review

  • Add relevant information to the sections below (Summary etc)
  • Rebase or merge the latest dev (or other targeted branch)
  • Update documentation if needed
  • Add an entry to the SPRINTLOG.md if needed
  • Choose an appropriate label. See here for information on the labelling options
  • The code follows the style guidelines
  • Perform a self-review: read the diff as if reviewing someone else's code
  • I have commented the code, particularly in hard-to-understand areas
  • Verify that all checks and tests have passed

If the target branch is master:

Summary

Describe what the PR changes and why.

Related Issue/Ticket

Link GitHub issue or provide Jira ID.

Testing

If applicable: How did you verify the change? Include commands, data, or screenshots.

Reviewer Notes

Anything that helps reviewers (e.g. areas needing close attention).


Once all boxes are checked, mark the PR as Ready for Review and tag at least one team member as the initial reviewer.

@ebbaoliveberg ebbaoliveberg added the type: bug Something isn't working label Nov 18, 2025
@ebbaoliveberg ebbaoliveberg marked this pull request as ready for review November 18, 2025 14:01
@ebbaoliveberg ebbaoliveberg requested a review from a team as a code owner November 18, 2025 14:01
@ebbaoliveberg ebbaoliveberg requested a review from valyo November 19, 2025 08:11
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor stuff with the imports, noice otherwise.
You can also link the issue in the PR description, more info/instructions are not needed then

Comment on lines 7 to +18
import datetime
import logging
import pathlib

# Standard library
from dataclasses import dataclass
from typing import List, Tuple, Union

import pytz
import tzlocal
from rich.markup import escape

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import datetime
import logging
import pathlib
# Standard library
from dataclasses import dataclass
from typing import List, Tuple, Union
import pytz
import tzlocal
from rich.markup import escape
# Standard library
import datetime
import logging
import pathlib
from dataclasses import dataclass
from typing import List, Tuple, Union
# Installed
import pytz
import tzlocal
from rich.markup import escape
from rich.padding import Padding
from rich.table import Table
from rich.tree import Tree
# Own modules
from dds_cli import DDSEndpoint, base, exceptions
from dds_cli import text_handler as th
import dds_cli.utils

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this applies for the entire IMPORTS section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants