-
Notifications
You must be signed in to change notification settings - Fork 12
Fix combine --size and --tree bug #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix combine --size and --tree bug #858
Conversation
valyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor stuff with the imports, noice otherwise.
You can also link the issue in the PR description, more info/instructions are not needed then
| import datetime | ||
| import logging | ||
| import pathlib | ||
|
|
||
| # Standard library | ||
| from dataclasses import dataclass | ||
| from typing import List, Tuple, Union | ||
|
|
||
| import pytz | ||
| import tzlocal | ||
| from rich.markup import escape | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import datetime | |
| import logging | |
| import pathlib | |
| # Standard library | |
| from dataclasses import dataclass | |
| from typing import List, Tuple, Union | |
| import pytz | |
| import tzlocal | |
| from rich.markup import escape | |
| # Standard library | |
| import datetime | |
| import logging | |
| import pathlib | |
| from dataclasses import dataclass | |
| from typing import List, Tuple, Union | |
| # Installed | |
| import pytz | |
| import tzlocal | |
| from rich.markup import escape | |
| from rich.padding import Padding | |
| from rich.table import Table | |
| from rich.tree import Tree | |
| # Own modules | |
| from dds_cli import DDSEndpoint, base, exceptions | |
| from dds_cli import text_handler as th | |
| import dds_cli.utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this applies for the entire IMPORTS section
Pull Request Template
Before Marking as Ready for Review
dev(or other targeted branch)SPRINTLOG.mdif neededIf the target branch is
master:Summary
Describe what the PR changes and why.
Related Issue/Ticket
Link GitHub issue or provide Jira ID.
Testing
If applicable: How did you verify the change? Include commands, data, or screenshots.
Reviewer Notes
Anything that helps reviewers (e.g. areas needing close attention).
Once all boxes are checked, mark the PR as Ready for Review and tag at least one team member as the initial reviewer.