-
Couldn't load subscription status.
- Fork 34
Add support for ax.locator_params() #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -185,5 +185,50 @@ def test_NetCDFTimeDateLocator_date_unit_warning(): | |
| NetCDFTimeDateLocator(5, "360_day", "days since 2000-01-01") | ||
|
|
||
|
|
||
| class Test_set_params(unittest.TestCase): | ||
| def setUp(self): | ||
| # list of maxs to trigger different resolutions | ||
| self.vmax_list = [0.0003, 0.02, 1, 30, 365, 5000] | ||
| self.params = {"nbins": 10, "min_n_ticks": 4} | ||
|
|
||
| def check(self, max_n_ticks, **kwargs): | ||
| # Create an instance of your class | ||
| locator = NetCDFTimeDateLocator( | ||
| max_n_ticks=max_n_ticks, calendar="gregorian" | ||
| ) | ||
| # Call the set_params method | ||
| locator.set_params(**kwargs) | ||
| return locator | ||
|
|
||
| def test_set_params(self): | ||
| for key, value in self.params.items(): | ||
| for vmax in self.vmax_list: | ||
| locator = self.check(3, **{key: value}) | ||
| ticks = locator.tick_values(0, vmax) | ||
| # Assert that the expected values are set and returned | ||
| if key == "nbins": | ||
| # not more than max + 1 | ||
| self.assertFalse(ticks.size > value + 1) | ||
| # make sure number of ticks increased from initial | ||
| self.assertTrue(ticks.size > 4) | ||
| elif key == "min_n_ticks": | ||
| # not less than min | ||
| self.assertFalse(ticks.size < value) | ||
| else: | ||
| raise ValueError( | ||
| "tests on parameters other than nbins and min_n_ticks are not" | ||
| " yet implemented" | ||
| ) | ||
|
|
||
| # Add more assertions to test the behavior of the method | ||
| # For example, you can assert that the internal state of the locator is updated correctly | ||
| self.assertEqual( | ||
| getattr(locator._max_n_locator_days, f"_{key}"), value | ||
| ) | ||
| self.assertEqual( | ||
| getattr(locator._max_n_locator, f"_{key}"), value | ||
| ) | ||
|
Comment on lines
+223
to
+230
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could go either way on including these checks. They are a nice explicit way of checking that the |
||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.