Skip to content

Conversation

@emigun
Copy link
Member

@emigun emigun commented Dec 4, 2025

Description

If editDatasetEnabled is true but editMetadataEnabled is false the Edit tab still shows.
This PR fixes that.

Changes:

  • remove [hidden] attribute
  • put both conditions in ngIf

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Bug Fixes:

  • Prevent the Edit tab from being shown when metadata editing is disabled in the application configuration.

@emigun emigun requested a review from a team as a code owner December 4, 2025 15:13
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@emigun emigun changed the title fix:only show Edit tab if editMetadataEnabled is true fix: only show Edit tab if editMetadataEnabled is true Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants