Remove candlepin_events test for Katello PR #11652

[jeremylenz]

Summary

Removes Robottelo test code that will break now that Katello PR Katello/katello#11652 is merged. That PR removes the Candlepin event listener infrastructure, which means candlepin_events will no longer appear in the /api/v2/ping API response.

Changes

1. Deleted test_positive_candlepin_events_processed_by_stomp() from tests/foreman/api/test_subscription.py

   • This test validated STOMP event processing from Candlepin
   • The functionality being tested no longer exists in Katello
   • Test would fail with KeyError when accessing candlepin_events service

2. Updated documentation comment in tests/foreman/api/test_ping.py

   • Removed candlepin_events from example response structure
   • Test logic unchanged and will continue working

Related PRs

• Katello: Refs #38953 - Remove Candlepin Event Listener and supporting code Katello/katello#11652 - Removes Candlepin Event Listener and supporting code
• Hammer CLI: Refs #38953 - Remove candlepin events from ping output Katello/hammer-cli-katello#1025 - Removes candlepin_events from ping output

Impact Analysis

• Breaking changes: 1 test deleted, 1 comment updated
• Nailgun changes: None needed (Ping entity has no hardcoded schema)
• Other ping tests: All continue working (use generic iteration patterns)
• Risk level: Low - only removes obsolete functionality

Testing

The remaining subscription tests will continue to work. The deleted test specifically validated removed functionality.

Summary by Sourcery

Remove obsolete tests and references related to Candlepin event listener removal.

Tests:

• Delete the Candlepin STOMP event processing subscription test that depends on the removed candlepin_events service.
• Update ping API example comment to no longer reference the candlepin_events service while keeping existing ping tests intact.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes a now-obsolete Candlepin STOMP events test that depends on the candlepin_events ping service and updates a ping test comment to reflect the removal of candlepin_events from the Katello ping API output.

File-Level Changes

Change	Details	Files
Remove obsolete Candlepin STOMP events integration test that depends on candlepin_events ping output.	Delete the RHEL 7-only test that verifies Candlepin events are processed via STOMP using the /api/v2/ping candlepin_events service. Remove inline helper function that parses Candlepin event messages and all assertions around Processed/Failed event counts and candlepin_events status. Eliminate polling logic that waited for candlepin_events Processed counter to increase after manifest upload.	tests/foreman/api/test_subscription.py
Align ping API example documentation with current schema that no longer exposes candlepin_events.	Update the commented example ping response to remove the candlepin_events service entry under katello services while leaving all test logic intact.	tests/foreman/api/test_ping.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[jeremylenz]

test-robottelo tests/foreman/api/test_subscription.py

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py

[jeremylenz]

trigger: test-robottelo
  pytest: tests/foreman/api/test_subscription.py

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py

[vijaysawant]

Need to add Label with stream / satellite version

[Satellite-QE]

PRT Result

Build Number: 15060
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_subscription.py --external-logging
Test Result : ================ 13 passed, 313 warnings in 1894.67s (0:31:34) =================

[adamlazik1]

LGTM