cmake: fix linking in xcb and wayland libraries#274
Open
johnzupin wants to merge 1 commit into
Open
Conversation
johnzupin
force-pushed
the
zupin-update-cmake
branch
from
3d0e7c5 to
82796f8
Compare
Author
|
Made some formatting changes, hitting "Hide whitespace" might help with review. |
Trying to compile vulkanCapsViewer using CMake with the params -DX11=YES and/or -DWAYLAND=YES would fail because the libraries were not being linked in. This change updates the cmake to link the appropriate libraries. Also, the file had a mix of CRLF and LF line endings, this commit updates to only have CRLF endings to be consistent with the repo. Also removed whitespace and updated indentation to be consistent. CMakeLists.txt - Updated formatting - indenting is consistent - Remove an old comment - Update logic if X11 or WAYLAND is specified and link appropriately in target_link_library calls
johnzupin
force-pushed
the
zupin-update-cmake
branch
from
82796f8 to
911fc18
Compare
Owner
|
Thx for the PR. I'm not using CMake for my builds, so if this is okay from your side I can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to compile vulkanCapsViewer using CMake with the params -DX11=YES and/or -DWAYLAND=YES would fail because the libraries were not being linked in. This change updates the cmake to link the appropriate libraries. Also, the file had a mix of CRLF and LF line endings, this commit updates to only have CRLF endings to be consistent with the repo. Also removed whitespace and updated indentation to be consistent.
CMakeLists.txt