Fix Metal layer detection in Qt 6.10 and newer#270
Merged
Conversation
Contributor
Author
|
Of course as-is, this patch would fail to launch on Qt <6.10, so let me know if you prefer a more flexible solution. |
Owner
|
As the caps viewer is also packaged with the SDK, and that isn't done by me, changes like these need to be backwards compatible. So yes, in order to take this, it needs to properly work with the current Qt version. |
9602a4d to
7fcadc4
Compare
Contributor
Author
|
The function now first checks if the view's own layer is a CAMetalLayer already, and only if it's not and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Qt 6.10, the Metal layer is nested in an intermediary QContainerLayer:
qt/qtbase@0bdbf46
This came up while bumping vulkan-caps-viewer in nixpkgs, where Qt6 is at version 6.10.2.
Error message on launch without this fix: