Release: NEX-GDDP historical split + compare_datasets parallelization (#72)#133
Merged
Conversation
…asets (#72) (#132) Two issues reported on #72, both verified: 1. NEX-GDDP returned only 2015-2016 for a 1990-2016 ssp245 request. The fetch filtered by a single scenario, but NASA/GDDP-CMIP6 stores <=2014 only under 'historical' and 2015+ under the SSP. Split any request crossing the 2014/2015 boundary into a 'historical' segment (<=2014) plus the SSP segment (>=2015) and concatenate, so the full period (and thus the climatology) is populated. Verified a 2013-2016 ssp245 run now returns all four years. 2. compare_datasets took ~15 min: the 16-model NEX-GDDP ensemble was fetched serially. Run the per-model fetches concurrently via ThreadPoolExecutor (capped at 10 to match the GEE connection pool), preserving input-model order. Also reconfigure stdout/stderr to UTF-8 in compare_datasets' CLI; its emoji status markers crashed cp1252 Windows consoles with UnicodeEncodeError (which masked the underlying fetch errors).
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes #132 from staging to main: fixes the NEX-GDDP historical/SSP boundary split (so requests spanning 2014/2015 return the full period instead of only 2015+), parallelizes the compare_datasets NEX-GDDP ensemble fetch, and adds the UTF-8 console fix. Resolves the reopened claims on #72.