fix: add circuit breaker to MongoDB logger to prevent repeated 10s connection delays - #105
Merged
SamXop123 merged 4 commits intoMay 29, 2026
Merged
Conversation
…GitHub GraphQL services
|
@rishab11250 is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
connectToDatabase()in logger.js attempts a full MongoDB connection on every API request. If MongoDB is unreachable, each request waits 10 seconds (serverSelectionTimeoutMS) before failing — and the next request retries the same 10s delay.The
connectionAttemptedvariable was declared on line 4 but never read. This fix uses it as a circuit breaker: once the first connection attempt completes (success or failure), all subsequent requests skip connecting entirely.Root Cause
After a failed connection:
connectingPromiseis reset tonullmongoose.connection.readyStatestays0Fix
connectionAttemptedbefore attempting connection — iftrueand not connected, skip immediatelyconnectionAttempted = truein all exit paths: success, failure, and missing URIBehavior change
Testing
npm run test:unit)Closes #101