Skip to content

More GPUs#128

Merged
SamXop123 merged 1 commit into
SamXop123:mainfrom
GauravKarakoti:GPU
Mar 3, 2026
Merged

More GPUs#128
SamXop123 merged 1 commit into
SamXop123:mainfrom
GauravKarakoti:GPU

Conversation

@GauravKarakoti

@GauravKarakoti GauravKarakoti commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Description

Added 5 more GPUs

**Fixes #113 **


Type of Change

  • New Feature (New PC component or category)
  • Bug Fix (Compatibility logic error or UI glitch)
  • Documentation (README, Mermaid diagrams, or comments)
  • Refactor (Code cleanup in lib/ or app/)
  • UI/UX Update (Framer Motion animations or shadcn/ui tweaks)

Compatibility & Logic Impact

Does this change affect the core building engines?

  • lib/compatibility.ts: Changes to socket matching, wattage, or form factors.
  • lib/suggestions.ts: Updates to the AI/Smart recommendation logic.
  • lib/data.ts: Modifications to the component database.

If yes, please describe the logic change: >
Added 5 more GPUs.


Contributor Checklist

  • Linting: I have run npm run lint and fixed all warnings.
  • Next.js 15: Verified the build works with the App Router.
  • Responsiveness: Tested on mobile and tablet breakpoints.
  • Mermaid: If I updated the README, I verified the Mermaid diagrams render correctly.
  • DSCWOC '26: I have tagged the project maintainer and used the correct labels.

Acknowledgments

  • I have read the Code of Conduct.
  • I am submitting this PR under the MIT License.

Built with love for RigCrafter

Summary by CodeRabbit

  • New Features
    • Expanded GPU catalog with five new models: ASUS ROG Astral 5090, Gigabyte Gaming OC 5090, ASUS TUF 5080, ASRock Steel Legend 9070XT, and ASUS Dual 6700XT.

@vercel

vercel Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

@GauravKarakoti is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@coderabbitai

coderabbitai Bot commented Mar 2, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The pull request expands the GPU catalog in lib/data.ts by adding five new gaming GPU entries, increasing the total GPU count from 6 to 10+ models. Each new GPU includes comprehensive metadata such as specifications, brand information, pricing, ratings, descriptions, images, and compatibility details.

Changes

Cohort / File(s) Summary
GPU Catalog Expansion
lib/data.ts
Added five new GPU entries (ASUS ROG Astral LC RTX 5090, Gigabyte Gaming OC RTX 5090, ASUS TUF RTX 5080, ASRock Steel Legend RX 9070 XT, ASUS Dual RX 6700 XT) with complete specifications, pricing, ratings, descriptions, images, tags, and compatibility configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

enhancement, level 3

Poem

🐰 Five new GPUs hop into the fray,
Gaming rigs will have more choice today,
ASUS, Gigabyte, ASRock all here,
RTX, Radeon crystals clear,
Rendering power, a rabbit's cheer! 🎮✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'More GPUs' is vague and generic, lacking specificity about the scope or nature of the GPU additions. Consider a more descriptive title like 'Add 5 new GPU entries to component database' to better reflect the specific change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The PR description is mostly complete, following the template structure with type of change, compatibility impact, and checklist items properly filled out.
Linked Issues check ✅ Passed The PR adds exactly 5 GPUs matching those suggested in issue #113, meeting the core requirement to expand GPU options from 6 to 10 with proper metadata.
Out of Scope Changes check ✅ Passed All changes are within scope—only the gpus array in lib/data.ts was modified with new GPU entries; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
lib/data.ts (1)

423-423: Prefer first-party hosted image assets for catalog stability.

These new entries use third-party hotlinked images. Consider hosting assets in a controlled bucket/CDN to avoid broken images, throttling, or licensing surprises in production.

Also applies to: 445-445, 467-467, 489-489, 511-511

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@lib/data.ts` at line 423, The catalog entries in lib/data.ts set imageUrl to
third-party hotlinks; replace those external URLs (properties named imageUrl)
with first-party hosted asset URLs or local/static asset references, e.g.,
upload each image to our controlled CDN/bucket and update the imageUrl values
for the affected items, or introduce a helper like hostedImage(filename) and use
hostedImage("81agXcNA6zL._AC_UY327_FMwebp_QL65_.jpg") for each product entry;
ensure all occurrences of imageUrl in this file (including the other entries
flagged) are updated and add a fallback/local placeholder if the hosted asset is
missing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/data.ts`:
- Around line 415-524: The PR added five GPU entries which increases GPU count
from 6 to 11 but Issue `#113` only allows adding 4; either remove one of the new
GPU objects (e.g., delete the object with id "gpu-asus-dual-6700xt" or any one
of the new ids "gpu-asus-rog-astral-5090", "gpu-gigabyte-gaming-oc-5090",
"gpu-asus-tuf-5080", "gpu-asrock-steel-legend-9070xt") to keep net additions to
4, or update the linked issue/acceptance criteria to permit 11 total GPUs and
reference that update in the PR description.
- Around line 415-436: The GPU entry lacks radiator-size compatibility data and
the app has no radiator-fit checks; update the Component interface's
compatibility object to include optional requiredRadiatorSizeMm?: number and
optional maxRadiatorSizeMm?: number, then populate case components'
compatibility.maxRadiatorSizeMm from their "Max Radiator" spec (extract that
value into the compatibility object for all case items), set the GPU's
compatibility.requiredRadiatorSizeMm to 360 for the ASUS ROG Astral item, and
finally add radiator validation in getCompatibilityIssues() to compare a GPU's
requiredRadiatorSizeMm against a case's maxRadiatorSizeMm (emit an
incompatibility if required > max or if one side is defined and the other is
missing as appropriate).

---

Nitpick comments:
In `@lib/data.ts`:
- Line 423: The catalog entries in lib/data.ts set imageUrl to third-party
hotlinks; replace those external URLs (properties named imageUrl) with
first-party hosted asset URLs or local/static asset references, e.g., upload
each image to our controlled CDN/bucket and update the imageUrl values for the
affected items, or introduce a helper like hostedImage(filename) and use
hostedImage("81agXcNA6zL._AC_UY327_FMwebp_QL65_.jpg") for each product entry;
ensure all occurrences of imageUrl in this file (including the other entries
flagged) are updated and add a fallback/local placeholder if the hosted asset is
missing.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfa64eb and c5ddc35.

📒 Files selected for processing (1)
  • lib/data.ts

Comment thread lib/data.ts
Comment thread lib/data.ts

@SamXop123 SamXop123 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅✅

@SamXop123 SamXop123 added level 3 Advanced dscwoc Data Science Club Winter Of Code 2026 labels Mar 3, 2026
@SamXop123 SamXop123 merged commit 333e9d1 into SamXop123:main Mar 3, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dscwoc Data Science Club Winter Of Code 2026 level 3 Advanced

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<Component> Add more GPU components

2 participants