Fix GCF extraction #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCF extraction was broken with the big initialOffset change, commit cd7e6ff#diff-6cb108a7e2e3e65bf9d0a75be0f79619f0aff47f2a96a9828dd6f67d288057af
GCF extraction previously read
afterMapPosition = data.Positionseveral times throughout the deserialization, to seek back to at relevant points. This commit changed some, but not all instances of afterMapPosition to initialOffset, resulting in a situation where the final offset reading went unused, and DataBlockHeader was being read from the previous offset.Mainly detailing this since there's still a remaining inconsistency in usage of afterMapPosition vs initialOffset in the file, and initialOffset seems strange to use after, well, the initial offset.