Skip to content

Conversation

brett060102
Copy link
Collaborator

@brett060102 brett060102 commented Jul 17, 2025

Add collection of lsmod and PCI data to the hwdata infor block

This done by adding a collector that will invoke
lspci -s .0 and lsmod

Requires adding pciutils to required package for suseconnect

The size of the additional payload in the heartbeat depends on how many pci devices are on the system and
number of modules loaded into the kernel. See:
https://confluence.suse.com/display/publiccloud/Design+-+PCI+Data+Collection
For more information.

Copy link
Contributor

@mssola mssola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a more general comment, please use goimports/gofmt. As in, your Go environment does not align at all with Go's coding conventions. This is something that should've been detected via our CI, but we never bothered to do so 😅 Hence, take a look at that, and run make check-format to ensure that your code is up to Go's coding conventions.

@brett060102
Copy link
Collaborator Author

Thank you for "gofmt" reference. I did not know about it. Does make things easier.

@brett060102 brett060102 changed the base branch from main to next August 11, 2025 20:38
@mssola
Copy link
Contributor

mssola commented Aug 12, 2025

By the way, does the WIP label still apply for this PR?

@brett060102
Copy link
Collaborator Author

yes, this should stay WIP for now. We don't want this to land until we know how it would effect RMT's and SCC.

@mssola
Copy link
Contributor

mssola commented Aug 13, 2025

Ok, then I will not review this further. Ping me again when you need another review.

@brett060102
Copy link
Collaborator Author

@mssola Thank you very much for all of your comments and inputs on this. It has helped a lot.

@brett060102 brett060102 force-pushed the pci-collector branch 2 times, most recently from b8e8271 to 06e5d40 Compare August 13, 2025 16:49
@mssola mssola force-pushed the next branch 2 times, most recently from ba2362b to 3b96875 Compare August 19, 2025 10:58
@brett060102 brett060102 force-pushed the pci-collector branch 2 times, most recently from 677ec83 to a82952b Compare August 27, 2025 06:19
Base automatically changed from next to main September 2, 2025 10:15
@brett060102 brett060102 force-pushed the pci-collector branch 7 times, most recently from 3cc85cd to ff353d9 Compare September 9, 2025 19:23
@brett060102 brett060102 force-pushed the pci-collector branch 9 times, most recently from 16cf9bc to 4dcd889 Compare September 16, 2025 15:56
@brett060102 brett060102 force-pushed the pci-collector branch 4 times, most recently from ce9ae58 to 92c1d95 Compare October 1, 2025 17:23
  and some debug to wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants