-
Notifications
You must be signed in to change notification settings - Fork 21
Add collector to get pci device data #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
292be7c
to
1ece975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a more general comment, please use goimports
/gofmt
. As in, your Go environment does not align at all with Go's coding conventions. This is something that should've been detected via our CI, but we never bothered to do so 😅 Hence, take a look at that, and run make check-format
to ensure that your code is up to Go's coding conventions.
Thank you for "gofmt" reference. I did not know about it. Does make things easier. |
1ece975
to
82b34b2
Compare
By the way, does the |
yes, this should stay WIP for now. We don't want this to land until we know how it would effect RMT's and SCC. |
82b34b2
to
5585dd7
Compare
Ok, then I will not review this further. Ping me again when you need another review. |
@mssola Thank you very much for all of your comments and inputs on this. It has helped a lot. |
b8e8271
to
06e5d40
Compare
ba2362b
to
3b96875
Compare
677ec83
to
a82952b
Compare
3cc85cd
to
ff353d9
Compare
ff353d9
to
94faef2
Compare
16cf9bc
to
4dcd889
Compare
ce9ae58
to
92c1d95
Compare
and some debug to wrapper
92c1d95
to
0e16f52
Compare
Add collection of lsmod and PCI data to the hwdata infor block
This done by adding a collector that will invoke
lspci -s .0 and lsmod
Requires adding pciutils to required package for suseconnect
The size of the additional payload in the heartbeat depends on how many pci devices are on the system and
number of modules loaded into the kernel. See:
https://confluence.suse.com/display/publiccloud/Design+-+PCI+Data+Collection
For more information.