preserve scroll position when changing display options#350
Open
duhdugg wants to merge 1 commit intoSTEPBible:masterfrom
Open
preserve scroll position when changing display options#350duhdugg wants to merge 1 commit intoSTEPBible:masterfrom
duhdugg wants to merge 1 commit intoSTEPBible:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story: I'm reading Psalm 119 on mobile. Halfway through, I want to add a translation and switch to column view. Or maybe I want to toggle verse numbers on or off. When I do any of this, I get scrolled back to the top and have to manually find my last known position again.
This PR solves for that by detecting the first verse in view before re-rendering the new data, then scrolling to that position after the re-render is complete.