Skip to content

feat/#269 Added onMouseUp Event #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat/#269 Added onMouseUp Event #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0251782
added onMouseUp event
vedhapre Dec 16, 2021
326b808
added event to play/index.js
vedhapre Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions play/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,30 @@ play("Carousel", module)
},
}
})
.add("non-touch slideclick event", {
template:
`<div style="width: 100%; display: flex; justify-content: center; margin-top: 40px;">
<carousel style="width: 500px;">
<slide v-for="slide in slides" :key="slide" @slideclick="onSlideClick">
<img style="width: 100%;" :src="slide" />
</slide>
</carousel>
</div>`,
components: {
Carousel,
Slide
},
data() {
return {
slides: images
}
},
methods: {
onSlideClick(currentDataset) {
this.$log(`Captured non touch slide click event. Current dataset is ${JSON.stringify(currentDataset)}`)
},
}
})
.add("slideclick event", {
template:
`<div style="width: 100%; display: flex; justify-content: center; margin-top: 40px;">
Expand Down
17 changes: 16 additions & 1 deletion src/Slide.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ export default {

this.$el.addEventListener(
this.carousel.isTouch ? "touchend" : "mouseup",
this.onTouchEnd
this.onTouchEnd,
this.onMouseUp
);
},
computed: {
Expand Down Expand Up @@ -103,6 +104,20 @@ export default {
this.$emit("slideclick", Object.assign({}, e.currentTarget.dataset));
this.$emit("slide-click", Object.assign({}, e.currentTarget.dataset));
}
},

onMouseUp(e) {
// On click for non-touch events only
const X_Axis_Pos = e.clientX;
const X_Axis_Change = this.carousel.dragStartX - X_Axis_Pos;

if (
this.carousel.minSwipeDistance === 0 ||
Math.abs(X_Axis_Change) < this.carousel.minSwipeDistance
) {
this.$emit("slideclick", Object.assign({}, e.currentTarget.dataset));
this.$emit("slide-click", Object.assign({}, e.currentTarget.dataset));
}
}
}
};
Expand Down