Skip to content

Update README step 5 and step 23 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README step 5 and step 23 #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30cf8f
Update README due to typo
oibafbruh Nov 6, 2025
858993b
Remove unused formatter from App controller and cleaned up InvoiceLis…
oibafbruh Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion steps/05/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ You can download the solution for this step here: [📥 download step 5](https:/
***

### webapp/controller/App.controller.?s \(New\)
First of all, we need a conroller for our app view that defines how the view should react to user inputs, such as a button press event.
First of all, we need a controller for our app view that defines how the view should react to user inputs, such as a button press event.

We create a new folder called `controller` inside the `webapp` folder. This folder will hold all our controller files. Inside the `controller` folder, we create a new file called `App.controller.?s`. We define the app controller in its own file by extending the OpenUI5-provided `sap/ui/core/mvc/Controller`. In the beginning, it holds only a single function called `onShowHello` that shows an alert with the static text "Hello World".

Expand Down
6 changes: 2 additions & 4 deletions steps/23/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ Finally we apply the filter to the items binding of the invoice list in our view
```ts
import Controller from "sap/ui/core/mvc/Controller";
import JSONModel from "sap/ui/model/json/JSONModel";
import formatter from "../model/formatter";
import { SearchField$SearchEvent } from "sap/m/SearchField";
import Filter from "sap/ui/model/Filter";
import FilterOperator from "sap/ui/model/FilterOperator";
Expand All @@ -54,13 +53,11 @@ import ListBinding from "sap/ui/model/ListBinding";
* @namespace ui5.walkthrough.controller
*/
export default class App extends Controller {
public formatter = formatter;

onInit(): void {
const viewModel = new JSONModel({
currency: "EUR"
});
this.getView()?.setModel(viewModel, "view");
this.getView()?.setModel(viewModel, "view");
}

onFilterInvoices(event: SearchField$SearchEvent): void {
Expand Down Expand Up @@ -136,6 +133,7 @@ In addition, we remove the `headerText` property in the list control and use `he
<mvc:View
controllerName="ui5.walkthrough.controller.InvoiceList"
xmlns="sap.m"
xmlns:core="sap.ui.core"
xmlns:mvc="sap.ui.core.mvc">
<List
id="invoiceList"
Expand Down