This repository was archived by the owner on Jul 19, 2021. It is now read-only.
Lock editing of individual armor stands#49
Open
dege16 wants to merge 2 commits intoRypoFalem:masterfrom
Open
Conversation
| } | ||
|
|
||
| void toggleLock(ArmorStand armorStand){ | ||
| NamespacedKey key = new NamespacedKey(plugin, "locked"); |
Contributor
There was a problem hiding this comment.
Don't recreate NamespacedKey - it's good to keep it in one place
| import java.util.ArrayList; | ||
| import java.util.Set; | ||
| import java.util.UUID; | ||
| import static jdk.nashorn.internal.objects.NativeObject.keys; |
Contributor
There was a problem hiding this comment.
I don't see it being used or even needed?
Comment on lines
+213
to
+217
| boolean isLocked(ArmorStand armorStand) { | ||
| NamespacedKey key = new NamespacedKey(plugin, "locked"); | ||
| PersistentDataContainer container = armorStand.getPersistentDataContainer(); | ||
| return container.has(key, PersistentDataType.BYTE); | ||
| } |
Contributor
There was a problem hiding this comment.
Not sure if duplicating this is needed. Can't the one used above be reused?
Comment on lines
+114
to
+119
| String asName = as.getCustomName(); | ||
| boolean asNameVisible = as.isCustomNameVisible(); | ||
| Bukkit.getScheduler().runTaskLater(plugin, () -> { | ||
| as.setCustomName(asName); | ||
| as.setCustomNameVisible(asNameVisible); | ||
| }, 1); |
Contributor
There was a problem hiding this comment.
What is this trying to do? It seems to do nothing, unless I'm missing some Bukkit quirk?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.