-
Couldn't load subscription status.
- Fork 78
Compiletest: pass -Zui-testing to rustc
#447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would squash together the 2nd and 3rd commits because they don't make sense in isolation (tests will fail if just the 2nd commit is applied). Otherwise, I'm not a rust-gpu reviewer, but LGTM. |
|
I was considering it, but didn't as it "hides" the " |
18c92d8 to
067b38b
Compare
It's mentioned in the first line of the commit message! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Thanks for doing this.
This is the dual of Rust-GPU/rust-gpu#447
This is the dual of Rust-GPU/rust-gpu#447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be perfectly honest, seeing this diff, the fact that we weren't using -Z ui-testing for the kind of tests named ui because of rustc testing infrastructure, is quite the facepalm moment 🤦.
Thanks for cleaning this up!
Supersedes #439, see discussions over there
-Zui-testingto rustc to improve compiletest normalization and have fewer conflicts