-
Notifications
You must be signed in to change notification settings - Fork 77
Update to nightly-2025-07-07
.
#420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Currently getting failures like this:
I will bisect locally to work out what's happening. EDIT: I am no longer getting this error since #380 merged. It's now a different error, see below. |
Nightly 2025-07-05 is the last good one; Nightly 2025-07-06 is the first bad one. The rust-lang/rust/ commit range between those two is I don't know if it's possible to bisect more finely than that because I don't know how to build rust-gpu with a locally built compiler. Having said that, the likely PR causing the problem is one of:
Because they are the only two PRs in the range that modify I suspect it's the former (143410) because that's about SIMD and the failing assertion has this comment:
i.e. it's some kind of SIMD padding issue. I'm out of my depth here, particularly on the rust-gpu side but even on the rustc side. @eddyb, do you know how to fix this? |
#380 replaces |
I did a whole lot of follow-up on this today. The problem identified above turned out to be a rustc bug and the change was later reverted, but then there were other problems with later nightlys as well and it got very complicated. But in short, yes, landing #380 will probably help. |
#380 is in 🎉 |
8051c24
to
036239e
Compare
I have updated, now trying to update to 2025-08-04, but I have
Lots of errors like this:
|
036239e
to
b24bc41
Compare
- We now get warnings about unnecessary parentheses around `dyn` types. - Spelling of `sf.name.prefer_remapped_unconditionaly` was fixed (now ends in `lly`). - `Pointer::into_parts` has been replaced with `Pointer::prov_and_relative_offset`.
- `BuilderMethods::dynamic_alloca` was removed. - `TargetDataLayout::pointer_{size,align}` were changed from fields to methods. - `AddressSpace::DATA` was renamed `AddressSpace::ZERO`.
- `run_fat_lto`, `optimize_fat`, and `autodiff` were merged into `run_and_optimize_fat_lto`, and the parameters were changed. - `run_thin_lto` parameters were changed. - `codegen` parameters were changed. - `LtoModuleCodegen` was removed. - Minor error message changes: - Some line number changes in rustc. - Some error message wording tweaks. The LTO changes occurred in rust-lang/rust PR 143388 and PR 144062.
b24bc41
to
327182c
Compare
- `tcx.get_attrs_unchecked(...)` was replaced with `tcx.get_all_attrs(...)`. - `run_link` has been removed. - `BuilderMethods::tail_call` was added. It's currently `todo!()`. - Adjust expected test outputs for very minor error message formatting changes. - And update to glam 0.30.8.
327182c
to
9727d5e
Compare
@eddyb: to summarize here:
|
dyn
types.sf.name.prefer_remapped_unconditionaly
was fixed (now ends inlly
).Pointer::into_parts
has been replaced withPointer::prov_and_relative_offset
.