gccrs: fix ICE in TyVar constructor #4206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkm
reviewed
Oct 13, 2025
gcc/rust/typecheck/rust-tyty-util.cc
Outdated
Comment on lines
34
to
36
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Usually for single statement, we skip the braces...
There was a problem hiding this comment.
Thanks for the review, @dkm
I've updated the code style to remove the unnecessary braces!
gcc/rust/typecheck/rust-tyty-util.cc
Outdated
Comment on lines
45
to
47
| if (!ok || lookup == nullptr) | ||
| { | ||
| return nullptr; |
gcc/rust/typecheck/rust-tyty-util.cc
Outdated
Comment on lines
106
to
108
| { | ||
| return TyVar::get_implicit_infer_var (UNKNOWN_LOCATION); | ||
| } |
gcc/rust/typecheck/rust-tyty-util.cc
Outdated
Comment on lines
121
to
123
| { | ||
| return TyVar::get_implicit_infer_var (UNKNOWN_LOCATION); | ||
| } |
Lishin1215
force-pushed
the
3556
branch
2 times, most recently
from
28f220a to
841af29
Compare
gcc/rust/ChangeLog: * typecheck/rust-tyty-util.cc (TyVar::TyVar): Add null check to avoid ICE. (TyVar::get_tyty): Return nullptr when lookup fails. (TyVar::clone): Handle null base type safely. (TyVar::monomorphized_clone): Add fallback for error types. gcc/testsuite/ChangeLog: * rust/compile/issue-3556.rs: New test. Signed-off-by: lishin <[email protected]>
philberty
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3556
The changes ensure that type lookup failures no longer trigger assertions.
If further support for this pattern is needed, I'm happy to discuss possible approaches further!
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: