[Dicey Tales] Bug fixes and enhancements : Fix rolls issues and optimize picture loading with webp images - #15357
Open
LeRatierBretonnien wants to merge 5 commits into
Open
[Dicey Tales] Bug fixes and enhancements : Fix rolls issues and optimize picture loading with webp images#15357LeRatierBretonnien wants to merge 5 commits into
LeRatierBretonnien wants to merge 5 commits into
Conversation
- Combat rolls now include the attribute (Agility by default, or the weapon's Melee - STR/Melee - AGI choice) and subtract the target's Defense.
- Weapon damage is dice + auto-computed Strength bonus (full for melee, half for hurled, none for ranged) with no stray prompts or zeros.
- Per-weapon Attack button rolls skill + attribute vs Defense.
- Creature damage uses a single die multiplied by the size multiplier, with no false Success/Failure verdicts.
- Blank attributes default to 0 via input value attributes (removes @{attr|default} that Roll20 misread as cross-character refs).
Convert all 30 PNGs to WebP (quality 90, same dimensions, RGBA preserved) to prepare for a WebP migration. Reduces total image payload from ~23 MB to ~3.1 MB. Originals kept.
Update all 52 image references in dicey_tales.html and dicey_tales.css from .png?raw=true to .webp?raw=true, pointing at the already-committed WEBP versions of the sheet graphics. Reduces image payload from ~23 MB to ~3 MB. sheet.json preview stays on preview.png.
Contributor
|
Character Sheet Info Roll20 Internal Use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The current updates has been requested by Jeff fMeija from Dicey Tales Production as the current Dicey Tales sheet are buggy.
Summary of changes
Remark
This is my firtst PR for Roll20, so let me know if I missed something or if something is wrong in my PR.
Thanks !