fix(fuselage): correct Slider track fill for non-zero minValue and RTL locales - #2169
Open
aniruddhaadak80 wants to merge 3 commits into
Open
fix(fuselage): correct Slider track fill for non-zero minValue and RTL locales#2169aniruddhaadak80 wants to merge 3 commits into
aniruddhaadak80 wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: b12ad2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commits
Fixes the
Slidertrack fill rendering in two scenarios where it did not match the actual thumb position:1. Non-zero
minValueproduced a wrong fill positiongetThumbPositioncomputed(value / (maxValue - minValue)) * 100, which ignores the offset ofminValue. For example, a slider withminValue={50}maxValue={150}and value100rendered its fill at 100% instead of 50%.The component now uses react-stately's own percent calculation (
state.getThumbPercent(index)), which also fixes multi-thumb sliders where each thumb can have a different range (previously both thumbs sharedgetThumbMaxValue(1) || getThumbMaxValue(0)).2. Horizontal fill ignored RTL direction
react-aria flips horizontal slider geometry in RTL locales, but the track gradient was hardcoded to
to right, so in RTL languages the filled portion appeared on the wrong side of the thumb. The gradient direction now followsuseLocale().direction.Evidence that the new tests catch the original bugs
Running the updated spec against the old
SliderTrack.tsx:With the fixed
SliderTrack.tsx:The vertical slider path is intentionally untouched:
to top+ percent-from-min was already correct for vertical orientation.@rocket.chat/fuselage patch changeset included.