feat(fuselage)!: Remove the ghost variant and the disabled prop from Badge - #2147
Merged
Conversation
…rom `Badge` The ghost variant was discontinued in favor of secondary and no longer exists in the design system. The disabled visual state was removed along with it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7d3273d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
juliajforesti
approved these changes
Aug 7, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2146 (closed automatically by a head-branch rename).
Summary
Task
ghostvariant from theBadgecomponent (type union, SCSS theme vars,&--ghostblock, and Storybookvariantoptions), following the design team decision recorded in the review of fix(fuselage-tokens): badge level-1 contrast a11y failing #2144:ghostwas discontinued in favor ofsecondaryand no longer exists in Figma.disabledprop and its visual state (prop, modifier class, SCSS vars/block, Storybook argType and story, spec coverage, and the corresponding visual regression golden).Both removals are breaking for external consumers, so the changeset follows the repo convention for 0.x breaking changes (
minorbump with afeat(fuselage)!:message identical to this PR title). A search on RocketChat/Rocket.Chat (viagh search code, 2026-08-07) confirmed no usage ofvariant='ghost'nor<Badge disabled>.Test plan
yarn jest Badge.spec— 9/9 passingyarn visual-regression-update— 506/506 passing; no golden changed besides the deletion ofdata-display-badge--disabled-desktop.png(there is no ghost story)yarn eslint/stylelint/prettierclean on the touched files; API report (fuselage.api.md) regenerated🤖 Generated with Claude Code