feat: Screen Sharing General Availability - #41837
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
|
| Layer / File(s) | Summary |
|---|---|
Feature-aware call controls packages/ui-voip/src/providers/MockedMediaCallProvider.tsx, packages/ui-voip/src/views/MediaCallRoomSection/MediaCallRoomSection.tsx, packages/ui-voip/src/views/MediaCallWidget/*, packages/ui-voip/src/views/MediaCallPopoutView.tsx |
Mock sessions accept supported features. Ongoing-call and popout controls render conditionally. Stories cover disabled features and screen-share-only support. |
Call room and configuration cleanup apps/meteor/client/views/room/body/MediaCallRoom.tsx, apps/meteor/ee/server/settings/voip.ts, packages/i18n/src/locales/* |
The room activity wrapper no longer skips rendering when screen sharing is unavailable. The screen-sharing alert metadata and obsolete translations are removed. |
Direct voice call test setup apps/meteor/tests/e2e/page-objects/fragments/voice-calls.ts, apps/meteor/tests/e2e/voice-calls-ee.spec.ts |
The page object supports username-based call initiation. Call, active-call, transfer, and decline scenarios use the navbar flow. Active-call tests verify that unsupported screen-sharing controls are hidden. |
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk: ⚪ Minimal · up to 46e29
This PR removes beta-only screen-sharing UI and availability gating. No actionable merge-blocking risk remains based on the supplied current-head evidence, so it is merge-ready after normal checks and review.
Sequence Diagram(s)
sequenceDiagram
participant MockedMediaCallProvider
participant MediaCallRoomSection
participant OngoingCall
participant MediaCallPopoutView
MockedMediaCallProvider->>MediaCallRoomSection: Provide supported media-call features
MediaCallRoomSection->>OngoingCall: Render supported call controls
MockedMediaCallProvider->>MediaCallPopoutView: Provide supported media-call features
MediaCallPopoutView->>MediaCallPopoutView: Gate feature-specific controls
Suggested labels: type: feature
Suggested reviewers: tassoevan
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly and concisely describes the main change: moving Screen Sharing to general availability. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (1)
- SSGA-33: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41837 +/- ##
===========================================
+ Coverage 69.25% 69.33% +0.07%
===========================================
Files 4234 4255 +21
Lines 167278 168644 +1366
Branches 29806 30360 +554
===========================================
+ Hits 115841 116921 +1080
- Misses 46279 46549 +270
- Partials 5158 5174 +16
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
tassoevan
left a comment
There was a problem hiding this comment.
Proposed changes (including videos or screenshots)
This PR officially moves Screen Sharing out of BETA 🥳
Issue(s)
SSGA-33
Steps to test or reproduce
Further comments
Summary by CodeRabbit