Skip to content

feat: Screen Sharing General Availability - #41837

Merged
dionisio-bot[bot] merged 8 commits into
developfrom
ui-voip/screensharingGA
Aug 20, 2026
Merged

feat: Screen Sharing General Availability#41837
dionisio-bot[bot] merged 8 commits into
developfrom
ui-voip/screensharingGA

Conversation

@gabriellsh

@gabriellsh gabriellsh commented Aug 18, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

This PR officially moves Screen Sharing out of BETA 🥳

  • Removes BETA tag
  • Removes Screen Sharing availability as a gate for the "Room View""
  • Removes unaccessible features from the UI, instead of disabling them visually

Issue(s)

SSGA-33

Steps to test or reproduce

Further comments

Review in cubic

Summary by CodeRabbit

  • New Features
    • Call controls now appear only when supported, including screen sharing, hold, and call transfer.
    • Calls can be started directly from the room toolbar for a selected contact.
  • Bug Fixes
    • Removed unsupported-feature labels and obsolete screen-sharing beta alerts.
    • Improved call control behavior when features are unavailable across call views.
  • Tests
    • Expanded coverage for direct calling, transfers, declined calls, and hidden screen-sharing controls.
    • Added scenarios for calls with different supported-feature combinations.

@dionisio-bot

dionisio-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ad5978e9-12ea-43ae-9523-d92ca0e7d439

📥 Commits

Reviewing files that changed from the base of the PR and between ad9dfd0 and 46e29c0.

📒 Files selected for processing (1)
  • packages/ui-voip/src/views/MediaCallPopoutView.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
⚠️ CI failures not shown inline (5)

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

  • packages/ui-voip/src/views/MediaCallPopoutView.tsx
packages/**

📄 CodeRabbit inference engine (CLAUDE.md)

Shared libraries belong in packages/, while other services belong in apps/ and ee/.

Files:

  • packages/ui-voip/src/views/MediaCallPopoutView.tsx
🔇 Additional comments (1)
packages/ui-voip/src/views/MediaCallPopoutView.tsx (1)

34-34: LGTM!

Also applies to: 85-105


Walkthrough

Media call sessions now expose configurable supported features. Hold, screen-share, and transfer controls render only when supported. Voice-call end-to-end tests start calls directly from the navbar.

Changes

Media call feature availability

Layer / File(s) Summary
Feature-aware call controls
packages/ui-voip/src/providers/MockedMediaCallProvider.tsx, packages/ui-voip/src/views/MediaCallRoomSection/MediaCallRoomSection.tsx, packages/ui-voip/src/views/MediaCallWidget/*, packages/ui-voip/src/views/MediaCallPopoutView.tsx
Mock sessions accept supported features. Ongoing-call and popout controls render conditionally. Stories cover disabled features and screen-share-only support.
Call room and configuration cleanup
apps/meteor/client/views/room/body/MediaCallRoom.tsx, apps/meteor/ee/server/settings/voip.ts, packages/i18n/src/locales/*
The room activity wrapper no longer skips rendering when screen sharing is unavailable. The screen-sharing alert metadata and obsolete translations are removed.
Direct voice call test setup
apps/meteor/tests/e2e/page-objects/fragments/voice-calls.ts, apps/meteor/tests/e2e/voice-calls-ee.spec.ts
The page object supports username-based call initiation. Call, active-call, transfer, and decline scenarios use the navbar flow. Active-call tests verify that unsupported screen-sharing controls are hidden.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 46e29

This PR removes beta-only screen-sharing UI and availability gating. No actionable merge-blocking risk remains based on the supplied current-head evidence, so it is merge-ready after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant MockedMediaCallProvider
  participant MediaCallRoomSection
  participant OngoingCall
  participant MediaCallPopoutView
  MockedMediaCallProvider->>MediaCallRoomSection: Provide supported media-call features
  MediaCallRoomSection->>OngoingCall: Render supported call controls
  MockedMediaCallProvider->>MediaCallPopoutView: Provide supported media-call features
  MediaCallPopoutView->>MediaCallPopoutView: Gate feature-specific controls
Loading

Suggested labels: type: feature

Suggested reviewers: tassoevan

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving Screen Sharing to general availability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • SSGA-33: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.33%. Comparing base (ea163f5) to head (46e29c0).
⚠️ Report is 20 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41837      +/-   ##
===========================================
+ Coverage    69.25%   69.33%   +0.07%     
===========================================
  Files         4234     4255      +21     
  Lines       167278   168644    +1366     
  Branches     29806    30360     +554     
===========================================
+ Hits        115841   116921    +1080     
- Misses       46279    46549     +270     
- Partials      5158     5174      +16     
Flag Coverage Δ
e2e 58.80% <ø> (-0.13%) ⬇️
e2e-api 45.87% <ø> (+<0.01%) ⬆️
unit 71.26% <52.38%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 46e29c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh
gabriellsh marked this pull request as ready for review August 19, 2026 11:59
@gabriellsh
gabriellsh requested a review from a team as a code owner August 19, 2026 11:59

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/meteor/tests/e2e/page-objects/fragments/voice-calls.ts
Comment thread apps/meteor/tests/e2e/voice-calls-ee.spec.ts
tassoevan
tassoevan previously approved these changes Aug 19, 2026

@tassoevan tassoevan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Too many boolean expressions in components' bodies.

tassoevan
tassoevan previously approved these changes Aug 19, 2026
@coderabbitai coderabbitai Bot added the type: feature Pull requests that introduces new feature label Aug 20, 2026
@FragaKrummenauer FragaKrummenauer added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2026
@gabriellsh gabriellsh added this to the 8.8.0 milestone Aug 20, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Aug 20, 2026
Merged via the queue into develop with commit 2a7de45 Aug 20, 2026
99 of 101 checks passed
@dionisio-bot
dionisio-bot Bot deleted the ui-voip/screensharingGA branch August 20, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: feature Pull requests that introduces new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants