Split host and port in .env variables#1363
Split host and port in .env variables#1363jerryfletcher21 wants to merge 1 commit intoRoboSats:mainfrom
Conversation
KoalaSat
left a comment
KoalaSat
left a comment
There was a problem hiding this comment.
Nice proposal! We shouldn't forget about double check if there is any effect on https://github.com/RoboSats/robosats-deploy, since its the software that coordinators run
|
If we want to add new variables for host/port split into two vars, we need to keep supporting the current variable names with deprecation notice. Re-factoring the Creating a PR in robosats-deploy is not enough: we have to document it (how an existing What is the motivation for splitting host and port into two variables? I agree it's cleaner, but not sure if worth the amount of trouble this upgrade can potentially cause. |
|
@Reckless-Satoshi yes the coordinators would have to change their |
jerryfletcher21
force-pushed
the
split-host-port
branch
2 times, most recently
from
5eda999 to
7b3c62e
Compare
Reckless-Satoshi
force-pushed
the
main
branch
2 times, most recently
from
9054b87 to
f9244e1
Compare
jerryfletcher21
force-pushed
the
split-host-port
branch
from
7b3c62e to
33a0ebe
Compare
| BASE_REDIS_URL = \ | ||
| "redis://" + str(config("REDIS_HOST", cast=str, default="localhost")) + \ | ||
| ":" + str(config("REDIS_PORT", cast=str, default="6379")) + \ | ||
| "/" + str(config("REDIS_DB_NUMBER", cast=str, default="1")) |
There was a problem hiding this comment.
Seems like REDIS_DB_NUMBER was not present previously
| REDIS_URL: redis://localhost:6379 | ||
| REDIS_HOST: localhost | ||
| REDIS_PORT: 6379 | ||
| REDIS_DB_NUMBER: 1 |
There was a problem hiding this comment.
same here, Iḿ not sure how this might affect running Coordinators
3 participants
What does this PR do?
Split host and port in .env variables.
Related to #1364.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.