Skip to content

Conversation

@salmonumbrella
Copy link

Summary

Changes

Issue #494 - Weekly View buttons intermittent display

Root cause: The original implementation used setTimeout with 0ms delay after hashchange, but the h1 element may not exist in the DOM yet on some page transitions.

Fix: Moved the button rendering logic into the existing h1Observer callback which uses createHTMLObserver to reliably detect when h1 elements with class rm-title-display appear. This ensures buttons are always rendered when the header is available.

Issue #409 - ISO week format support

Added documentation for ISO week-numbering tokens that are already supported:

  • I / II - ISO week number
  • R / RRRR - ISO week-numbering year

Examples like {monday:RRRR}-W{monday:II}[[2024-W52]] now documented.

Test plan

  • Navigate to a weekly note page - buttons should appear
  • Navigate away and back - buttons should appear consistently
  • Try using ISO week format like {monday:RRRR}-W{monday:II}
  • Verify navigation buttons work with ISO week format

@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025

Warning

Rate limit exceeded

@salmonumbrella has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 93e5548 and 2d19b1d.

📒 Files selected for processing (2)
  • docs/weekly-notes.md
  • src/features/weekly-notes.ts
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weekly View buttons intermittently not showing up Support Week I YYYY as a weekly format

1 participant