feat: add statically compiled native-tls to binary#801
Open
b4iterdev wants to merge 1 commit intoRightNow-AI:mainfrom
Open
feat: add statically compiled native-tls to binary#801b4iterdev wants to merge 1 commit intoRightNow-AI:mainfrom
b4iterdev wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originally
native-tlspulls inopensslas a transitive dependency for IMAP support, andnative-tlsdoesn't use the vendored feature by default. It links against the system's libssl, which on Debian Trixie is OpenSSL 3.x (libssl3), not libssl.so.1.0.0. As a result, runningopenfangon Debian trixie will results inThis PR add
features = ["vendored"]into native-tls. Which causes it (and the imap crate's transitive OpenSSL dependency) to statically compile OpenSSL rather than link against the system's libssl at runtime. The binary will no longer depend on libssl.so.1.0.0 being present on the target system.Previously, commit 135c37f adds
features = ["vendored"]toopenssl, however it does not fully resolve the linking issue.Changes
features = ["vendored"]tonative-tlsTesting
cargo clippy --workspace --all-targets -- -D warningspasses: Proofcargo test --workspacepasses: ProofSecurity