Fix Gemini INVALID_ARGUMENT crash after message trimming#796
Open
pbranchu wants to merge 2 commits intoRightNow-AI:mainfrom
Open
Fix Gemini INVALID_ARGUMENT crash after message trimming#796pbranchu wants to merge 2 commits intoRightNow-AI:mainfrom
pbranchu wants to merge 2 commits intoRightNow-AI:mainfrom
Conversation
Add sanitize_gemini_turns() to enforce Gemini's strict turn-ordering constraints after message history is trimmed. This merges consecutive same-role turns, drops orphaned functionCall/functionResponse parts, and removes empty turns. Also adds #[serde(default)] on GeminiContent.parts and fixes two tests that were missing required ToolResult messages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- test_sanitize_drops_orphaned_function_call - test_sanitize_keeps_valid_function_call_response_pair - test_sanitize_drops_orphaned_function_response - test_sanitize_merges_consecutive_same_role - test_sanitize_empty_input Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitize_gemini_turns()function to enforce Gemini's strict turn-ordering constraints after message history trimmingfunctionCallparts (no followingfunctionResponse), drops orphanedfunctionResponseparts (no precedingfunctionCall), and removes empty turns#[serde(default)]onGeminiContent.partsto handle missing parts in API responsestest_thought_signature_not_echoed_without_metadataandtest_gemini_3x_text_and_function_call_both_have_signatures) that were missing requiredToolResultmessages, which caused sanitization to strip orphaned function callsTest plan
🤖 Generated with Claude Code