Fix MCP bridge dropping tool results when servers send notifications#789
Open
pbranchu wants to merge 1 commit intoRightNow-AI:mainfrom
Open
Fix MCP bridge dropping tool results when servers send notifications#789pbranchu wants to merge 1 commit intoRightNow-AI:mainfrom
pbranchu wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
…ions Read response lines until finding a JSON-RPC response matching the request ID. Previously, the bridge read one line and assumed it was the response, causing "No result from MCP tools/call" when MCP servers send notifications or log lines before the actual result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read MCP response lines until finding a JSON-RPC response matching the request ID, instead of assuming the first line is the response.
Problem
When an MCP server sends notifications or log lines on stdout before the tool result, the bridge reads the first line, fails to find a
resultfield, and returns "No result from MCP tools/call". This affects MCP servers likegoogle-workspace-mcpthat emit status messages during tool execution.Fix
Loop reading lines, parsing each as JSON-RPC, and matching by request
id. Non-matching responses, notifications, and non-JSON lines are skipped. Respects the existing timeout.Test plan
cargo checkpasses🤖 Generated with Claude Code