chore: clean up oxlint pedantic warnings#448
Closed
YogliB wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What
Cleaned up the current oxlint pedantic warnings by refactoring test helpers and splitting an oversized unit test file.
Why
Keep the lint bar higher without silencing rules or weakening the current quality gate.
Changes
test/helpers.tsto remove unnecessary async/promise wrappers while keeping the same call shapes for callers.test/integration/runner.tswhile removing a redundant async wrapper.test/unit/lazy-git.test.ts.test/unit/utils.test.tsinto smaller describe blocks so the file passes pedantic without disablingmax-lines-per-function.pedanticenabled atwarnin.oxlintrc.jsonso future warnings stay visible.Testing
How you verified this (commands, scenarios, or N/A):
bunx oxlint --import-plugin --deny-warnings test/helpers.ts test/integration/runner.ts test/unit/lazy-git.test.ts test/unit/utils.test.tsbun run testwas not run; the verification here was the focused lint pass plus targeted unit/integration tests.Targeted tests passed: 11/11.
Automated tests (
bun run test)Manual / CLI check if user-facing behavior changed
CI passes
Review notes
Breaking changes (or none)
None.
Risks / rollout (or none)
Low risk; the change is test-only cleanup with no production code behavior changes.
Focus areas for reviewers (optional)
The main thing to verify is that the helper refactors preserve the existing async/mock contract and that no lint rule was suppressed.
Checklist