Uiux/discovery empty error states#130
Open
gabrieltemtsen wants to merge 1 commit into
Open
Conversation
- Add DiscoveryState discriminated union (loaded | filtered-empty | truly-empty | error) to drive the result area in InvestorDiscovery - Wire search input and filter toggle to live state resolution - Add DiscoveryEmptyState component (exported, independently testable) - 'filtered' variant: echoes query, shows clear-filters CTA - 'truly-empty' variant: reassuring copy + how-it-works CTA - Add DiscoveryErrorState component (exported, independently testable) - Retry button with attempt counter (singular/plural copy) - role='alert' + aria-live='assertive' for immediate SR announcement - Add __simulateState prop for test/Storybook state overrides - Add progressbar role + aria-valuenow/min/max on funding bars - Add aria-pressed on filter toggle button - Add aria-live='polite' on result section and filter indicator - Add 10 design-system CSS tokens (--ds-*) and 11 component classes (.discovery-state-container, .discovery-state-icon-wrap, --empty / --error modifiers, .discovery-state-title/body/query/ retry-hint/action, .discovery-filter-btn--active/badge) WCAG 2.1 AA: SC 1.3.1, 1.4.3, 2.1.1, 2.4.3, 2.4.7, 4.1.3 addressed Tests (src/components/InvestorDiscovery.test.tsx): - 64 tests across 10 groups - 97.56% stmts / 97.87% branches / 100% funcs / 100% lines - Coverage threshold ≥95% enforced in vite.config.ts Docs (docs/uiux/ux107-discovery-empty-error-states.md): - State model, component API tables, token reference, CSS class list, layout diagram, ARIA table, WCAG mapping, test coverage summary Closes RevoraOrg#107
gabrieltemtsen
force-pushed
the
uiux/discovery-empty-error-states
branch
from
6795ff2 to
5371654
Compare
|
@gabrieltemtsen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #107