Conversation
…g on member variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently in draft stage. My code is spaghetti, and I don't really like that, but we may need to live with it for now. Also, please let me know of any additional improvements you might want to be added. This is mostly a fix for recent Ghidra regressions (bringing it back up to where it was before), so I would love to go further and make it better.
EDIT: It's also built on top of my Kotlin build changes branch, because I prefer the
.ktsscripts.EDIT 2: The changes to
SelectorTrampolineAnalyzer.ktare left over from when I edited it, saved it, and the file auto-formatted in my editor. I reverted the actual changes I made, but not the auto-formatting.