[DO NOT MERGE] Added Paywalls entrypoint documentation #1239
Conversation
|
Preview this PR here: https://dev-docs.revenuecat.com/pr-1239/ |
Jethro87
changed the title
chrisfree
left a comment
chrisfree
left a comment
There was a problem hiding this comment.
I didn't get to completely get through this review, but posting some feedback anyhow.
Co-authored-by: Chris Free <[email protected]>
Co-authored-by: Chris Free <[email protected]>
Co-authored-by: Chris Free <[email protected]>
Co-authored-by: Chris Free <[email protected]>
…Cat/docs into jeff/entrypoint-paywalls
|
@chrisfree I think this is ready for a final review |
chrisfree
left a comment
chrisfree
left a comment
There was a problem hiding this comment.
Some minor changes. I must admit, I don't have the means to test these code samples. How do we usually handle that?
Co-authored-by: Chris Free <[email protected]>
…Cat/docs into jeff/entrypoint-paywalls
|
@chrisfree I built test apps to test the code. iOS worked great, just getting Android up and running. Also asked the SDK team to review. |
tonidero
left a comment
tonidero
left a comment
There was a problem hiding this comment.
Left some comments for the android part, I'm not as familiarized with the iOS part, but will take a look later
ajpallares
left a comment
ajpallares
left a comment
There was a problem hiding this comment.
Looking good! I have some comments though
|
@tonidero @ajpallares Thank you for your reviews! After thinking more about this, I decided to follow Toni's suggestion and remove the StoreKit/Billing Client implementations. It felt that providing a non-comprehensive solution was worse than either extreme - just linking to the documentation vs a full implementation. I chose the former. Sorry for the hassle! @chrisfree I think this is good now. |
ajpallares
left a comment
ajpallares
left a comment
There was a problem hiding this comment.
I think it looks great! Just some minor comments
Co-authored-by: Antonio Pallares <[email protected]>
Motivation / Description / Changes introduced
Created a separate page for the Paywalls-only entrypoint. Details how to use Paywalls with the customer's existing purchase infrastructure.