Helpstyle: fix remaining inconsistent layout alignment and styling#873
Open
lioneil wants to merge 5 commits intoRetroPie:masterfrom
Open
Helpstyle: fix remaining inconsistent layout alignment and styling#873lioneil wants to merge 5 commits intoRetroPie:masterfrom
lioneil wants to merge 5 commits intoRetroPie:masterfrom
Conversation
Fix/helpsystem: Fix unstyled help hints
Collaborator
|
Thanks for sending this over! Let me take a look at this and revert. |
pjft
reviewed
Jun 14, 2024
| const std::string& name2, const std::function<void()>& func2, | ||
| const std::string& name3, const std::function<void()>& func3) : GuiComponent(window), | ||
| mBackground(window, ":/frame.png"), mGrid(window, Vector2i(1, 2)) | ||
| GuiMsgBox::GuiMsgBox(Window *window, const std::string &text, |
Collaborator
There was a problem hiding this comment.
Could we revert these types of changes if possible, as they're stylistic but not really functional? Thanks.
Collaborator
|
Thank you for putting this together. I tested it and it's working as intended. Could you add it to the Edit Metadata window as well, and potentially squash everything into a single commit? Any minor adjustments to the code - such as the comment I left regarding minor code style changes - can be applied in the same. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #146.
Fixes various Help hints in the Main Menu dialog not inheriting the current theme's styling.
Sample:
I'm using the same theme for both screenshot.
Before (help hint is supposed to be centered):
After the fix:
Before (Comic-Book theme, help hints are unstyled):
After:
There are other screens with the same issues: scraper menu, deeper down the custom collection submenus, the TextEdit dialogs, etc.
Hopefully this fixes all of them.
Note: I am not really a C++ developer, so you might see some poor choices I made in code.