Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the id3 crate with lofty for audio metadata management, expanding support to formats like FLAC, WAV, OGG, and M4A. It also adds the ability to update and embed album cover art into audio files. The review feedback highlights a potential risk in using Picture::new_unchecked without prior image data validation and suggests a performance optimization for file extension filtering during the library import process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
id3crate with theloftycrate to provide multi-format metadata support (including FLAC, OGG, M4A, etc.). The entire tag parsing, persistence, lyrics sync, and track cover functionalities have been re-architected.Changes:
id3in favor oflofty(v0.21.1) inCargo.toml.lofty::Probefor format-agnostic metadata extraction.ItemKey::Lyricsformat instead of MP3-specific[USLT]frames.MetadataEditorwith genericTaggedFileExtandAccessortraits and addedupdate_track_coverto enable replacing custom cover art.update_track_coverup throughPlaylistTableService,LibraryService, andAppCoreto expose the capability to the front-end directly.Closes metadata scaling requests and expands functionality beyond MP3 files.